Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consistent white-spaces #40

Open
wants to merge 13 commits into
base: upstream-patched
Choose a base branch
from
Open

Add consistent white-spaces #40

wants to merge 13 commits into from

Conversation

expedia-shawn
Copy link

This ensures consistency in code spacing, making code easier to read.

sammirata and others added 13 commits January 26, 2016 22:39
@sammirata @mstorsjo
Add support for Workgroup 4 (WG4) channel mapping
b480108 
This is the channel ordering used in DVD Audio, and is the standard
used internally in the VLC media player.
@mstorsjo
Allow setting bitrate modes 1-5 too
5936bc9 
These correspond to different VBR modes.
@mstorsjo
Add automake/autoconf source files
6a2034b 
Also add examples.
@mstorsjo
Avoid casting arbitrary values to an enum
4be022a 
The enum only contains the constant values 0, 1 and 2. This produces
the warning "comparison of constant 6 with expression of type
'PS_RESOLUTION' is always false" in clang for the first check
in the getNoBands function (but apparently not for the second one
even though mode>=3 shouldn't ever happen for a valid PS_RESOLUTION
value either). This could allow the compiler to completely remove
the conditions that shouldn't be able to occur even though they
actually are used and are necessary.

By passing the value as UINT instead, it is clear to the compiler
that all the checks are necessary.
@mstorsjo
Include the library versions in the publicly installed headers
73bce38 
This allows callers to conditionally use new API features without
breaking compatibility with the earlier versions of the library.
@mark4o @mstorsjo
Fix PowerPC Mac build
afa3e1b
@mark4o @mstorsjo
Add ppc optimization for clz and fixmul
98ec15e 
Optimize ppc/ppc64 similar to i386/x86_64, approximately doubling
encoding speed on a Power Mac G5 running OS X 10.5.8.
@mark4o @mstorsjo
Fix AIX build
2060a2b 
Fix AIX build failure with IBM xlC compiler due to conflicting
definition of M_PI.  The libSYS/include/genericStds.h definition is
guarded with #ifndef M_PI, but was included before <math.h> which
defines M_PI with more significant digits.
@mstorsjo
Extend GetInvInt to support values up to 79
f68ff15 
For sample rates >= 64 kHz with short blocks, the largest sfb
width is 36, which after grouping can be multiplied with 3,
ending up as 108. GetInvInt needs to be able to support
the largest grouped sfb width, divided by two (3 * 36 / 2 = 54).

This fixes VBR encoding with sample rates >= 64 kHz.

This is a bug fix patch from Fraunhofer, which will show up in AOSP
in the next code drop as well.
@jasperla @mstorsjo
Fix the preprocessor statements controlling the use of mips{32,64}r1 …
e2446a1 
…instructions.

Only enable code using mips32/mips64 instructions if the compiler is targetting
this ISA. (integer madd and msub instructions aren't available in the
``canonical'' mips ISAs)
@mstorsjo
libFDK/include/mips/cplx_mul.h: use C code instead of ASM
bdc359f 
Replace the assembler code by the equivalent in C. This way it will work
for every MIPS ISA. Now the check for __mips_isa_rev < 6 is no longer
necessary, so remove it.

Signed-off-by: Vicente Olivert Riera <[email protected]>
@mstorsjo
Remove android specific diagnostic logging
7ce2379
@expedia-shawn
Add consistent white-spaces
e2868a7
@mstorsjo
Copy link
Owner

I'm a bit reluctant to include this.

This isn't an independent project on its own, it's a repackaging of the AAC codec from Android. I include as few differences to the original upstream code as possible, to make sure maintainance of it is manageable - I don't want to diverge functionally or stylistically from the original, or in practice, as little as possible. (The differences mainly are in having a different build system, fixing crashes before the fixes get included in the Android version later, fixing other issues that don't matter in the Android context, etc.)

In this case, you could try to get the whitespace fixed in Android (in the platform/external/aac repo) - in that case the fix will get included here later.

@mstorsjo mstorsjo force-pushed the upstream-patched branch from 53bf9f2 to 0ff3222 Compare May 18, 2016 07:16
@mstorsjo mstorsjo force-pushed the upstream-patched branch from 29e4d6c to 2428f8c Compare July 5, 2018 20:03
@mstorsjo mstorsjo force-pushed the upstream-patched branch 2 times, most recently from e80dd8e to c3cef6d Compare April 28, 2021 12:50
@mstorsjo mstorsjo force-pushed the upstream-patched branch from d2efdf7 to 7e2eb5e Compare May 31, 2022 10:29
@mstorsjo mstorsjo force-pushed the upstream-patched branch 2 times, most recently from d11b8c9 to 14922d3 Compare October 6, 2023 13:38
@mstorsjo mstorsjo force-pushed the upstream-patched branch 2 times, most recently from 60034fc to dae91a2 Compare December 21, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@expedia-shawn @mstorsjo @sammirata @mark4o @jasperla