solvespace: New Package #22758
Draft
solvespace: New Package #22758
+340
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazka
reviewed
Dec 8, 2024
Comment on lines
+34
to
+35
| patch -N -p1 -i "${srcdir}/1487.patch" || true | ||
| patch -N -p1 -i "${srcdir}/002-not-in-msys2-temp.patch" || true |
There was a problem hiding this comment.
the first patch is from PR but it's from upstream which is not the version we are packaging, the rejects are then fixed/backported in 002-not-in-msys2-temp.patch, however the second one a || true is not necessary, you're right.
There was a problem hiding this comment.
I'd argue it doesn't make sense in both cases. It shouldn't fail, and if it does we want to know.
There was a problem hiding this comment.
I guess I can manually remove the reject chunks, however they might be necessary on a later version
|
the resulting package is empty, so something is broken in the package() phase |
It seems it's an upstream problem.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the 1487.patch refers to the PR, and because this patch is on release it will not exactly work for the tagged version, so the 002*.patch is a hotfix which should be removed whenever they tag a new version.