Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msys2-runtime{,3.4}: restore msys-2.0.dbg #4600

Merged
merged 2 commits into from
May 20, 2024

Conversation

jeremyd2019
Copy link
Member

Replicate the objcopy commands that used to work in msys2-runtime build process.

also, don't strip msys2-runtime-devel. makepkg's strip mechanism thinks split debug files are binaries that need to be stripped, and debug files with the debug info stripped are pretty useless. msys2/msys2-pacman#52

Fixes #4595

@jeremyd2019
Copy link
Member Author

If this is acceptable, I can apply the same changes to msys2-runtime-3.4

Replicate the objcopy commands that used to work in msys2-runtime build
process.

also, don't strip msys2-runtime-devel.  makepkg's strip mechanism thinks
split debug files are binaries that need to be stripped, and debug files
with the debug info stripped are pretty useless.  msys2/msys2-pacman#52

Fixes msys2#4595
After the update of msys2-w32api from v11.0.1 to current master (and
soon to be v12) we get: winsup/cygwin/exceptions.cc:1736:33: error:
'<anonymous>' may be used uninitialized [-Werror=maybe-uninitialized]

Ignore it like the rest.

Fixes msys2/msys2-runtime#214
@jeremyd2019 jeremyd2019 force-pushed the msys2-runtime-split-debuginfo-2 branch from 418078d to 374a194 Compare May 17, 2024 18:23
@jeremyd2019 jeremyd2019 changed the title msys2-runtime: restore msys-2.0.dbg msys2-runtime{,3.4}: restore msys-2.0.dbg May 17, 2024
@jeremyd2019
Copy link
Member Author

I applied these changes to msys2-runtime-3.4, and added -Wno-error=maybe-uninitialized to both. msys2-runtime-3.3 didn't appear to need either.

@lazka lazka merged commit ef02eda into msys2:master May 20, 2024
2 checks passed
@lazka
Copy link
Member

lazka commented May 20, 2024

nice, thanks

@jeremyd2019 jeremyd2019 deleted the msys2-runtime-split-debuginfo-2 branch May 20, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msys2-runtime-devel: missing debug info
2 participants