Fix Wayland window associations #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! It looks like we just need to add a |
Done. |
mtkennerly
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wayland compositors use the
appId/desktopFileNamewindow property in order to associate open windows with the correct.desktopfile. Ludusavi wasn't setting this field, and iced doesn't appear to have any default behavior around it (Qt for example sets it by default to the binary name) which was causing it to be empty. This would mean that Wayland compositors would never associate ludusavi windows with the ludusavi.desktop launcher, which for example would cause KDE Plasma to show the generic Wayland icon in the top left of the and in the overview. If Ludusavi was pinned to a task manager clicking on it would also result in windows being opened as a new entry and not grouped under the Ludusavi icon. Fix both of those issues and various other erroneous behavior by setting theappIdto the correct string (it should be the name of the.desktopfile without the.desktopextension).Before:
After:
