-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Improve DX of importing Base UI components #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
core
Infrastructure work going on behind the scenes
dx
Related to developers' experience
labels
Oct 2, 2024
Netlify deploy preview |
flaviendelangle
added a commit
to flaviendelangle/mui-x
that referenced
this pull request
Oct 3, 2024
This still works with tree-shaking if you test a minimal Vite repo and build for production? |
Yes, the resulting bundle does not contain the code of unused parts. |
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Oct 14, 2024
atomiks
approved these changes
Oct 14, 2024
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Oct 14, 2024
1 task
mj12albert
pushed a commit
to mj12albert/base-ui
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed how components are exported. Previously we had two index files:
index.ts
containing unprefixed component names (such as Root, Input, Indicator) andindex.barrel.ts
with full names (SwitchRoot, CheckboxIndicator). The former was supposed to be used asimport * as Foo from '@base_ui/react/Foo
, while the latterimport { FooRoot } from '@base_ui/react'
.Now we still have two index files per component, but only index.ts is meant to be imported.
index.parts.ts
aggregates and exports all parts of a component, whileindex.ts
reexports them and names the exported namespace.This makes all component parts accessible only through the component namespace:
Closes #650