-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Make React context definitions consistent #735
Conversation
Netlify deploy preview |
691c6c8
to
bd31a3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks for the context display name fixes.
export const RadioRootContext = React.createContext<RadioRootContext | null>(null); | ||
export const RadioRootContext = React.createContext<RadioRootContext | undefined>(undefined); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set default value of contexts to undefined (was a mix of undefined and null previously)
Ok, so a new standard. I think we can standardize on this in Material UI and X too.
undefined
(was a mix ofundefined
andnull
previously)displayName
in non-production environment (closes [dx] Missing React.createContext displayName #628)Closes #520