Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update test to use public API #44875

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

oliviertassinari
Copy link
Member

Help with mui/mui-x#16017

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Dec 28, 2024
@mui-bot
Copy link

mui-bot commented Dec 28, 2024

Netlify deploy preview

https://deploy-preview-44875--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 17da119

@oliviertassinari oliviertassinari added test dx Related to developers' experience labels Dec 28, 2024
@zannager zannager requested a review from DiegoAndai December 30, 2024 10:54
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the standard? If so, we need to add a lint rule to enforce it in the future. Currently, ./ and @mui/utils/ imports are used throughout the tests.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jan 2, 2025

Should this be the standard?

It already the standard e.g. https://github.com/mui/base-ui/blob/master/packages/react/src/dialog/description/DialogDescription.test.tsx#L2

I agree with having a lint rule, though, I don't know how this can be implemented.

@DiegoAndai DiegoAndai merged commit 3b15909 into mui:master Jan 3, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dx Related to developers' experience test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants