[core] Clean up "autoHeight" logic #16017
Open
+37
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
deprecate-autoHeight
branch
from
37b5a5e to
92626e4
Compare
oliviertassinari
added
component: data grid
|
Deploy preview: https://deploy-preview-16017--material-ui-x.netlify.app/ |
oliviertassinari
force-pushed
the
deprecate-autoHeight
branch
from
fdd7fce to
ddf58d3
Compare
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
deprecate-autoHeight
branch
from
ddf58d3 to
0da9c23
Compare
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
michelengelen
approved these changes
Jan 2, 2025
| @@ -389,6 +389,7 @@ describe('<DataGridPro /> - Detail panel', () => { | |||
| const getDetailPanelHeight = spy(() => 100); | |||
| const { setProps } = render( | |||
| <TestCase | |||
| autoHeight | |||
There was a problem hiding this comment.
this should also be removed, no?
There was a problem hiding this comment.
Some of the tests failed. I tried to remove as many as I could.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #14614.
http://0.0.0.0:3000/material-ui/getting-started/templates/dashboard/ uses this
autoHeightdeprecated prop, but there is no warning in the console. I found this by chance. I would have found this instantly it it was in the console.I have tried to add:
but there are a couple of tests that fail. Overall, I'm not sure that we can remove the
autoHeightprop:For example: https://mui.com/x/react-data-grid/layout/#flex-parent-container
Screen.Recording.2024-12-28.at.18.26.32.mov
I suspect it's what the failing tests are about when removing
autoHeight: https://app.circleci.com/pipelines/github/mui/mui-x/76597/workflows/92dfe153-bf52-47c1-9ddc-4df5357a69f6/jobs/435999 and https://app.circleci.com/pipelines/github/mui/mui-x/76597/workflows/92dfe153-bf52-47c1-9ddc-4df5357a69f6/jobs/436000.