[tree view] Explore a better plugin model API

[flaviendelangle]

It is purely a private API but I'm trying to prepare the headless tree view step by step.

The problems I am trying to solve here are:

• The controlledProp is not needed because the model name (the key of the object in useXXX.models) has to be equal to the controlled props (otherwise I can't deduce the type of models.xxx.value from the props).

  Solutions:

  • Remove the controlledProp from the model initialized and always use the model name.

• The defaultValueProp do not enforce that props[defaultValueProp] contains a value compatible with the controlled prop type.

  Solutions:

  • Replacing it with a callback (it makes the API slightly more verbose but it solves this issue)

• Calling models.xxx.setValue do not call the props callback (e.g: props.onExpandedNodesChange). This is very problematic because any plugin can call models.xxx.setValue but it's always a bad idea to do it.

  Solutions:

  • Removing the models.xxx.setValue on the typings of models defined in dependencies of the plugin makes sure that, at least with TS, you can't do this mistake.
  • Renaming models.xxx.setValue => models.xxx.setControlledValue to reduce the risk when using pure JS. To have a real safeguard we would need to generate the models object for each plugin, I'm not sure the perf overhead is worth it.

[mui-bot]

Deploy preview: https://deploy-preview-11567--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 1b05695

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[LukasTy]

LGTM. 👍