[pickers] Stop root exporting locales

[LukasTy]

Fixes #10918

• Remove root locales re-exporting
  • import { frFR } from '@mui/x-date-pickers'; would no longer work after this, but we never endorse such usage in the docs anyway.
• Keep root re-exporting l10n related types.
• Re-export locales via @mui/x-date-pickers-pro/locales.

Let's review the approach, if we are fine with it, then I'll:

• Add migration guide entry
• Add codemod Don't see much point in having it given all circumstances

[mui-bot]

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

• Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

  [l10n] Improve Swedish (sv-SE) locale
  [l10n] Add Danish (da-DK) locale

• Update the documentation of supported locales by running yarn l10n
• Verify that you have added an export line in src/locales/index.ts for the new locale.
• Run yarn docs:api which should add your new translation to the list of exported interfaces.
• Clean files with yarn prettier.

Deploy preview: https://deploy-preview-11612--material-ui-x.netlify.app/

Updated pages:

• docs/data/migration/migration-pickers-v6/migration-pickers-v6.md

Generated by 🚫 dangerJS against 392c310

[michelengelen]

LGTM

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[flaviendelangle]

OK to go with it since the discussion for depth 3 are far from over 👌

[flaviendelangle]

We just need some migration guide and maybe codemod before merging

[LukasTy]

We just need some migration guide and maybe codemod before merging

I've added the migration guide entry.
WDYT about it @flaviendelangle?

I have given some thought about adding a codemod and concluded that IMHO it's not worth the effort to maybe replace 1 import for 1 in 100 user cases.
If we had encouraged using root-level imports previously, I think it could make sense to add it, but given our current documentation, I don't think it's worth it. 🤷 🙈
WDYT? 🤔

[flaviendelangle]

I have given some thought about adding a codemod and concluded that IMHO it's not worth the effort to maybe replace 1 import for 1 in 100 user cases.
If we had encouraged using root-level imports previously, I think it could make sense to add it, but given our current documentation, I don't think it's worth it. 🤷 🙈
WDYT?

I'd be in favor of doing the codemod because it's fairly easy to do and adding a green check on the migration guide improves the overall feeling that the migration is easy.
But if you think it's wasted time I won't fight to have it 😆

[LukasTy]

I'd be in favor of doing the codemod because it's fairly easy to do and adding a green check on the migration guide improves the overall feeling that the migration is easy.

I would agree with you and kind of think that in the Data Grid case, it might make sense (however, they didn't add one, at least for now) because their demos had examples of importing locales from the root. 🤔
If I understand correctly. any new codemod means yet another iteration over every file in a given project. Because of that, in my head, it just means wasted resources and time on someone else's end. 🙈 🤷

[oliviertassinari]

Same as #11650 (comment)

Suggested change

	- import { frFR } from '@mui/x-date-pickers';
	+ import { frFR } from '@mui/x-date-pickers/locales';
	-import { frFR } from '@mui/x-date-pickers';
	+import { frFR } from '@mui/x-date-pickers/locales';

[LukasTy]

Thanks for bringing it up.
Raised a PR fixing it and some other tiny issues. 😉
#11695

[oliviertassinari]

Bundle size in https://bundlephobia.com/ is now smaller, cool

https://bundlephobia.com/package/@mui/[email protected]

https://bundlephobia.com/package/@mui/[email protected]

[LukasTy]

Bundle size in https://bundlephobia.com/ is now smaller, cool

Nice!. 👏
The difference on Data Grid side is even greater, because their localisation files are bigger.

[oliviertassinari]

Now, to be fair, technically, people will see an increase in v7 vs. v6 (data grid & date picker)

https://bundlephobia.com/package/@mui/[email protected]

https://bundlephobia.com/package/@mui/[email protected]

This is also visible when using https://marketplace.visualstudio.com/items?itemName=wix.vscode-import-cost

Still, marketing-wise, it's a win 👍 #10918 (comment)

[flaviendelangle]

For the pickers, I think it's due to our double textfield approach, we bundle both the TreeView and the new component.

[oliviertassinari]

Connecting this to #5550