Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fields] Support farsi digits #11639

Merged
merged 12 commits into from
Jan 12, 2024
Merged

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jan 10, 2024

Fixes #11488

  • Initial rendering with leading zeros should use farsi digits
  • Editing with arrows should work
  • Digit editing should work both with localized and non-localized digits

@flaviendelangle flaviendelangle marked this pull request as draft January 10, 2024 09:25
@flaviendelangle flaviendelangle self-assigned this Jan 10, 2024
@flaviendelangle flaviendelangle added component: pickers This is the name of the generic UI component, not the React module! feature: Keyboard editing Related to the pickers keyboard edition bug 🐛 Something doesn't work labels Jan 10, 2024
@mui-bot
Copy link

mui-bot commented Jan 10, 2024

Deploy preview: https://deploy-preview-11639--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d73d560

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 11, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 11, 2024
@flaviendelangle flaviendelangle marked this pull request as ready for review January 11, 2024 13:11
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀
Leaving a suggestion for avoiding the potential problem of introducing a fragile secondsNoLeadingZeros format. 😉

@flaviendelangle flaviendelangle merged commit d537fba into mui:next Jan 12, 2024
15 checks passed
@flaviendelangle flaviendelangle deleted the localized-digits branch January 12, 2024 13:54
@nikkorn
Copy link

nikkorn commented Jan 15, 2024

@flaviendelangle Thanks very much for this

@flaviendelangle
Copy link
Member Author

If you have the opportunity the test it, it would help us fix any problematic bug before the stable release.
It's always hard to test localization topic because we don't know the setup very well

@mazenadel19
Copy link

I can confirm that It has worked correctly after adding

        slotProps={{
            field: { shouldRespectLeadingZeros: true },
        }}

and I'm no longer seeing 0NaN,

thanks you @flaviendelangle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! feature: Keyboard editing Related to the pickers keyboard edition
Projects
None yet
5 participants