[DataGrid] Performance: avoid layout invalidation #12238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-12238--material-ui-x.netlify.app/ |
packages/x-data-grid/src/hooks/features/columns/useGridColumns.tsx
Outdated
Show resolved
Hide resolved
packages/x-data-grid/src/hooks/features/virtualization/useGridVirtualScroller.tsx
Outdated
Show resolved
Hide resolved
packages/x-data-grid/src/hooks/features/virtualization/useGridVirtualScroller.tsx
Show resolved
Hide resolved
| @@ -436,6 +441,9 @@ export const GridRootStyles = styled('div', { | |||
| }, | |||
| '&.Mui-selected': selectedStyles, | |||
| }, | |||
| [`.${c.virtualScrollerContent} > .${c.row}`]: { | |||
| position: 'absolute', | |||
There was a problem hiding this comment.
The dynamic row height experience feels worse with this change because rows overlap:
Screen.Recording.2024-02-28.at.16.10.07.mov
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on some of the work in #12023, split here to make review/merge easier.
Changes:
position: absoluterows to avoid layout invalidationvirtualScrollerRenderZone, not needed anymore since sticky{ colSpan: 1 }, to avoid expensive computations on every row render