Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Korean(ko-KR) locale #15878

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[l10n] Improve Korean(ko-KR) locale #15878

merged 2 commits into from
Dec 16, 2024

Conversation

good-jinu
Copy link
Contributor

@good-jinu good-jinu commented Dec 14, 2024 •
edited
Loading

  • I have followed (at least) the PR section of the contributing guide.

Related to #3211

@good-jinu good-jinu marked this pull request as draft December 14, 2024 01:01
@mui-bot
Copy link

mui-bot commented Dec 14, 2024 •
edited
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-15878--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4522fa5

@good-jinu good-jinu marked this pull request as ready for review December 14, 2024 01:08
@good-jinu good-jinu force-pushed the locale/update-korean-locale branch from 3231c29 to fe6e906 Compare December 14, 2024 13:28
@alexfauquette alexfauquette added component: data grid This is the name of the generic UI component, not the React module! l10n localization labels Dec 16, 2024
@arminmeh arminmeh added needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Dec 16, 2024
@arminmeh
Copy link
Contributor

Thank you @good-jinu

@arminmeh arminmeh merged commit ea72b70 into mui:master Dec 16, 2024
26 checks passed
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Dec 16, 2024
@good-jinu @web-flow
[l10n] Improve Korean(ko-KR) locale (#15878)
f9ccbe6
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Merged
lauri865 pushed a commit to lauri865/mui-x that referenced this pull request Dec 19, 2024
@good-jinu @lauri865
[l10n] Improve Korean(ko-KR) locale (mui#15878)
a07b40f
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
@good-jinu @LukasTy
[l10n] Improve Korean(ko-KR) locale (mui#15878)
f6fcc92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminmeh arminmeh arminmeh approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@good-jinu @mui-bot @arminmeh @alexfauquette