Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Fix column pinning with checkbox selection and row grouping #15908

Merged
merged 5 commits into from
Dec 19, 2024
Merged

[DataGridPremium] Fix column pinning with checkbox selection and row grouping #15908

merged 5 commits into from
Dec 19, 2024

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Dec 16, 2024 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Dec 16, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15908--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 3e30f3d

@k-rajat19 k-rajat19 marked this pull request as ready for review December 16, 2024 14:14
@k-rajat19
Copy link
Contributor Author

hi @michelengelen , can you review this please?

michelengelen
michelengelen reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far ... could you add tests for this to prevent any regressions? Thanks!

@michelengelen michelengelen added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Column groups Related to the data grid Column groups feature feature: Column pinning Related to the data grid Column pinning feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Dec 16, 2024
@arminmeh arminmeh enabled auto-merge (squash) December 19, 2024 19:58
@arminmeh arminmeh changed the title [DataGridPremium] Fix column unpinning with row grouping [DataGridPremium] Fix column pinning with checkbox selection and row grouping Dec 19, 2024
@arminmeh arminmeh merged commit 38eabdb into mui:master Dec 19, 2024
18 checks passed
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
@k-rajat19 @arminmeh @web-flow
[DataGridPremium] Fix column unpinning with row grouping (#15908)
6bfdece 
Co-authored-by: Armin Mehinovic <[email protected]>
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Merged
@k-rajat19 k-rajat19 deleted the issue-15808 branch December 20, 2024 02:27
lauri865 pushed a commit to lauri865/mui-x that referenced this pull request Dec 20, 2024
@k-rajat19 @arminmeh @lauri865
[DataGridPremium] Fix column unpinning with row grouping (mui#15908)
b21b65f 
Co-authored-by: Armin Mehinovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen left review comments

@arminmeh arminmeh arminmeh approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Column groups Related to the data grid Column groups feature feature: Column pinning Related to the data grid Column pinning feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Wrong position for Checkbox column after unpinning other column
4 participants
@k-rajat19 @mui-bot @arminmeh @michelengelen