Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove production profiler from docs build #15959

Merged
merged 1 commit into from
Dec 20, 2024
+1 −1
Merged

[docs] Remove production profiler from docs build #15959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"author": "MUI Team",
"license": "MIT",
"scripts": {
"build": "rimraf ./export && cross-env NODE_ENV=production next build --profile && pnpm build-sw",
"build": "rimraf ./export && cross-env NODE_ENV=production next build && pnpm build-sw",
Copy link
Member

@oliviertassinari oliviertassinari Dec 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon initially added this flag in mui/material-ui#21975.

I'm making the connection as it seems that this started with upgrading Next.js 14.2.20 -> 15.1.1 #15144.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I repro this? Would be helpful to get specifics here since profiling is currently in development so the earlier we find these issues, the better.

Copy link
Contributor Author

@lauri865 lauri865 Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare the below – drag the scrollbar up and down to see the visible difference (flash of content with profiler vs. no flash without):

"build:clean": "rimraf .next && pnpm build",
"build-sw": "node ./scripts/buildServiceWorker.js",
"dev": "next dev --port 3001",
Expand Down
Loading