[fields] Handle focusing container with inputRef.current.focus on accessibleFieldDOMStructure
#15985
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accessibleFieldDOMStructure`
LukasTy
added
component: pickers
|
Deploy preview: https://deploy-preview-15985--material-ui-x.netlify.app/ |
michelengelen
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when looking into #15967.
The controlled section selection demo no longer works after the components were changed to an accessible DOM structure.
I choose to pursue an approach where users would not see a breaking change.
Previous usages of
inputRef?.current.focus()would continue working on v8. 👍If you think that this is not worth it, then we have a breaking change and potentially need to make
unstableFieldRefstable and recommend refactoring tofieldRef?.current.focusField().