[core][data grid] Fix useTimeout clear lifecycle #16031
Open
+56
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
| @@ -1 +0,0 @@ | |||
| export { default as useTimeout } from '@mui/utils/useTimeout'; | |||
There was a problem hiding this comment.
It seems that nobody depends on this file, dead code.
|
Deploy preview: https://deploy-preview-16031--material-ui-x.netlify.app/ |
oliviertassinari
force-pushed
the
data-grid-fix-root-causes
branch
from
842ef67 to
830a42e
Compare
oliviertassinari
force-pushed
the
data-grid-fix-root-causes
branch
from
830a42e to
4f477c8
Compare
Comment on lines
+2
to
+6
| /** | ||
| * TODO, remove this file, have dependents import from: | ||
| * import useTimeout from '@mui/utils/useTimeout'; | ||
| * directly. | ||
| */ |
There was a problem hiding this comment.
Only brought it back so we can quickly learn if this is correct or wrong (meaning so we can merge #16031, before mui/material-ui#44897, so we test it with a smaller userbase.
oliviertassinari
force-pushed
the
data-grid-fix-root-causes
branch
from
4f477c8 to
b407d7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To read first: mui/material-ui#44897. Refs a guaranteed to be cleaned up until unmounted, so if they are missing, we are cleaning up too late.
So I don't think #14987's two PR fixes are correct.