[pickers] Infer mask from inputFormat
#5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
alexfauquette
changed the title
inputFormat
alexfauquette
commented
Jun 1, 2022
Comment on lines
-49
to
-54
| expect(runMaskValidation).toWarnDev( | ||
| [ | ||
| `The mask "${mask}" you passed is not valid for the format used ${format}.`, | ||
| `Falling down to uncontrolled no-mask input.`, | ||
| ].join('\n'), | ||
| ); |
There was a problem hiding this comment.
I removed the The mask ... you passed because when masked is inferred, it does not make sens to show this error message to the dev
alexfauquette
commented
Jun 1, 2022
Comment on lines
-20
to
-25
| const maskMap = { | ||
| fr: '__/__/____', | ||
| en: '__/__/____', | ||
| ru: '__.__.____', | ||
| de: '__.__.____', | ||
| }; |
There was a problem hiding this comment.
Since default mask is inferred, this can be done
packages/x-date-pickers/src/internals/utils/text-field-helper.ts
Outdated
Show resolved
Hide resolved
flaviendelangle
approved these changes
Jun 8, 2022
alexfauquette
force-pushed
the
get-mask-from-format
branch
from
9e2fc26 to
673b61f
Compare
Merged
joserodolfofreitas
pushed a commit
to joserodolfofreitas/mui-x
that referenced
this pull request
Jun 13, 2022
alexfauquette
added a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
oliviertassinari
added
the
component: pickers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4890
Fix #4756
The idea is that is mask is not defined, we try to infer it from the
inputFormatthis allows to support at the same time libraries that use uppercase letters forampmand library using lowercaseTo run test, I based this PR on #5055
Changelog
The mask can now be inferred from the
inputFormat.This allows supporting different separators like
dd/MM/YYYY,dd-MM-YYYY,dd.MM.YYYYand different orders such asMM-dd-YYYY,YYYY-MM-ddwithout having to specify themaskpropTo be accepted, the input format needs to b made of digits (months can not be
Jan,Fev, ...) and with fix length (January must be01and not1).You can still use
disableMaskedInputto disable this feature and providemaskprop to override the inferred mask.