-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Throw if date adapter is not found #5289
[test] Throw if date adapter is not found #5289
Conversation
let adapter = 'date-fns'; | ||
const availableAdapters = { | ||
'date-fns': AdapterDateFns, | ||
dayjs: AdapterDayjs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed it from day-js
to dayjs
to match package name https://www.npmjs.com/package/dayjs
These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice refinement
8bd6aac
to
1663ac2
Compare
* Throw if date adapter is not found * add comment
* Throw if date adapter is not found * add comment
Follow up on #5055
Before:
moments
adapter was not found, sodate-fns
was used by default. There's no indication of adapter used in tests and if you didn't notice the typo ("moments") it looks like tests passed withmoment
adapterAfter:
If adapter is not found - it will just throw.