-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #7340
Bump dependencies #7340
Conversation
9618ec9
to
218e241
Compare
3f1cde3
to
06524f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 54 of 54 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)
android/lib/resource/src/main/res/values/plurals.xml
line 6 at r1 (raw file):
<item quantity="other">%d years left</item> </plurals> <plurals name="months_left">
Great that these were removed!
android/gradle/verification-metadata.xml
line 5100 at r1 (raw file):
</artifact> </component> <component group="org.checkerframework" name="checker-qual" version="3.43.0">
This seems like a new dependency, could it be worth looking into why it was added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)
android/gradle/verification-metadata.xml
line 5100 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
This seems like a new dependency, could it be worth looking into why it was added?
According to dependencies:
_internal-unified-test-platform-android-device-provider-ddmlib - A configuration to resolve the Unified Test Platform dependencies.
\--- com.android.tools.utp:android-device-provider-ddmlib:31.7.3
+--- com.android.tools:common:31.7.3
| +--- com.android.tools:annotations:31.7.3
| +--- com.google.guava:guava:32.0.1-jre
| | +--- com.google.guava:failureaccess:1.0.1
| | +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
| | +--- com.google.code.findbugs:jsr305:3.0.2
| | +--- org.checkerframework:checker-qual:3.33.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
android/gradle/verification-metadata.xml
line 5100 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
According to dependencies:
_internal-unified-test-platform-android-device-provider-ddmlib - A configuration to resolve the Unified Test Platform dependencies. \--- com.android.tools.utp:android-device-provider-ddmlib:31.7.3 +--- com.android.tools:common:31.7.3 | +--- com.android.tools:annotations:31.7.3 | +--- com.google.guava:guava:32.0.1-jre | | +--- com.google.guava:failureaccess:1.0.1 | | +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava | | +--- com.google.code.findbugs:jsr305:3.0.2 | | +--- org.checkerframework:checker-qual:3.33.0
Amazing dependency:
com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
But looks good to me!
Generating it from gradle task will fail on CI due to relative path not being correct.
06524f4
to
8e9061b
Compare
Fixes: DROID-1663
This change is