Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #7340

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Bump dependencies #7340

merged 9 commits into from
Dec 17, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Dec 13, 2024

Fixes: DROID-1663


This change is Reviewable

@Rawa Rawa added the Android Issues related to Android label Dec 13, 2024
@Rawa Rawa self-assigned this Dec 13, 2024
Copy link

linear bot commented Dec 13, 2024

@Rawa Rawa requested review from Pururun, kl and albin-mullvad December 13, 2024 08:54
@Pururun Pururun added the On hold Means the PR is paused for some reason. No need to review it for now label Dec 13, 2024
@Rawa Rawa force-pushed the bump-dependencies-3 branch 4 times, most recently from 9618ec9 to 218e241 Compare December 16, 2024 08:48
@Rawa Rawa removed the On hold Means the PR is paused for some reason. No need to review it for now label Dec 16, 2024
@Rawa Rawa force-pushed the bump-dependencies-3 branch 3 times, most recently from 3f1cde3 to 06524f4 Compare December 17, 2024 08:46
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 54 of 54 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)


android/lib/resource/src/main/res/values/plurals.xml line 6 at r1 (raw file):

        <item quantity="other">%d years left</item>
    </plurals>
    <plurals name="months_left">

Great that these were removed!


android/gradle/verification-metadata.xml line 5100 at r1 (raw file):

         </artifact>
      </component>
      <component group="org.checkerframework" name="checker-qual" version="3.43.0">

This seems like a new dependency, could it be worth looking into why it was added?

Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)


android/gradle/verification-metadata.xml line 5100 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This seems like a new dependency, could it be worth looking into why it was added?

According to dependencies:

_internal-unified-test-platform-android-device-provider-ddmlib - A configuration to resolve the Unified Test Platform dependencies.
\--- com.android.tools.utp:android-device-provider-ddmlib:31.7.3
     +--- com.android.tools:common:31.7.3
     |    +--- com.android.tools:annotations:31.7.3
     |    +--- com.google.guava:guava:32.0.1-jre
     |    |    +--- com.google.guava:failureaccess:1.0.1
     |    |    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
     |    |    +--- com.google.code.findbugs:jsr305:3.0.2
     |    |    +--- org.checkerframework:checker-qual:3.33.0

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


android/gradle/verification-metadata.xml line 5100 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

According to dependencies:

_internal-unified-test-platform-android-device-provider-ddmlib - A configuration to resolve the Unified Test Platform dependencies.
\--- com.android.tools.utp:android-device-provider-ddmlib:31.7.3
     +--- com.android.tools:common:31.7.3
     |    +--- com.android.tools:annotations:31.7.3
     |    +--- com.google.guava:guava:32.0.1-jre
     |    |    +--- com.google.guava:failureaccess:1.0.1
     |    |    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
     |    |    +--- com.google.code.findbugs:jsr305:3.0.2
     |    |    +--- org.checkerframework:checker-qual:3.33.0

Amazing dependency:

com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava

But looks good to me!

@Rawa Rawa force-pushed the bump-dependencies-3 branch from 06524f4 to 8e9061b Compare December 17, 2024 13:57
@Rawa Rawa merged commit c5f4347 into main Dec 17, 2024
33 of 34 checks passed
@Rawa Rawa deleted the bump-dependencies-3 branch December 17, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants