Add DAITAv2 on iOS #7387
Merged
Add DAITAv2 on iOS #7387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkisemils
force-pushed
the
add-daita-v2-functionality-ios-971
branch
from
9e67146 to
32ab32c
Compare
dlon
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Reviewed 5 of 20 files at r1.
Reviewable status: 5 of 20 files reviewed, all discussions resolved
acb-mv
previously approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Reviewed 15 of 20 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
pinkisemils
force-pushed
the
add-daita-v2-functionality-ios-971
branch
3 times, most recently
from
3d8ad83 to
1901d74
Compare
dlon
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Reviewed 5 of 16 files at r2.
Reviewable status: 15 of 26 files reviewed, all discussions resolved (waiting on @acb-mv)
mullvad-ios/src/ephemeral_peer_proxy/mod.rs line 48 at r2 (raw file):
// The `packet_tunnel` pointer must be valid, much like the call in `fail_exchange`, but // since the other arguments here are non-null, these pointers (`preshared_ptr`, // `ephmerela_ptr` and `daita_ptr`) have to be valid too. Since they point to local
nit: ephmerela_ptr
pinkisemils
force-pushed
the
add-daita-v2-functionality-ios-971
branch
2 times, most recently
from
963c4eb to
747d7bc
Compare
pinkisemils
force-pushed
the
add-daita-v2-functionality-ios-971
branch
from
747d7bc to
25381c8
Compare
hulthe
approved these changes
Dec 27, 2024
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the back of @buggmagnet and @dlon work, I've gone and rebased things and touched everything up. These changes enable DAITAv2 on iOS. It seems to work 🤷.
These changes depend on mullvad/wireguard-apple#34 being merged first.
This change is