-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection detail toggle to connection view #7388
base: main
Are you sure you want to change the base?
Add connection detail toggle to connection view #7388
Conversation
ed4c80d
to
5d3630b
Compare
f9a3da3
to
3e1c133
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 32 files reviewed, 2 unresolved discussions
ios/MullvadRustRuntimeTests/MullvadPostQuantum+Stubs.swift
line 15 at r1 (raw file):
@testable import WireGuardKitTypes // swiftlint:disable function_parameter_count
Everything in this file is to make the unit tests work (currently failing when looking for MullvadTypes.WgFuncPointers
).
ios/convert-assets.rb
line 35 at r1 (raw file):
"icon-fail.svg", "icon-info.svg", "icon-reload.svg",
Added as a pure SVG in project assets instead of being converted here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 31 of 32 files at r1, 1 of 4 files at r2.
Reviewable status: 29 of 32 files reviewed, 5 unresolved discussions (waiting on @rablador)
ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ChipView/ChipViewModelProtocol.swift
line 25 at r1 (raw file):
for (index, chip) in chips.enumerated() { let textWidth = chip.name.width(using: .preferredFont(forTextStyle: .subheadline)) let chipWidth = textWidth + 16 /* inside horisontal padding */ + 8 /* outside trailing padding */
typo: should be "horizontal"
ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ChipFeature.swift
line 24 at r1 (raw file):
var name: String { String("DAITA")
Is the `String("
ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ChipView/ChipFeature.swift
line 85 at r2 (raw file):
var name: String { String("Server IP override")
Is the String("...")
wrapper necessary? IIRC,"Server IP override"
would return a String
3e1c133
to
e14ae14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 28 of 32 files reviewed, 4 unresolved discussions (waiting on @acb-mv)
ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ChipFeature.swift
line 24 at r1 (raw file):
Previously, acb-mv wrote…
Is the `String("
Done.
ios/MullvadVPN/View controllers/Tunnel/FeatureIndicators/ChipView/ChipFeature.swift
line 85 at r2 (raw file):
Previously, acb-mv wrote…
Is the
String("...")
wrapper necessary? IIRC,"Server IP override"
would return aString
Done.
084940c
to
750b18f
Compare
750b18f
to
fd11f54
Compare
fd11f54
to
0633867
Compare
0633867
to
118080b
Compare
The connection details should be shown/hidden depending on if the view is expanded or collapsed, via the tappable chevron. This PR does this, adds expandable state and implements the feature indicators in a feature complete package.
Note: This PR also includes https://linear.app/mullvad/issue/IOS-932/add-feature-indicator-pills-to-connection-details.
To do before release:
TunnelViewController
,TunnelControllView
,TunnelState+UI
etc.TunnelCoordinator
).To do at some point:
There's a bug when connecting and disconnecting where the buttom part of the connection view loses corner radius and is moved slightly upward. The behavior is inconsistent and require som bug bashing.Can't seem to trigger it anymore...Other:
This change is