Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade thiserror to version 2 #7414

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Upgrade thiserror to version 2 #7414

merged 1 commit into from
Jan 3, 2025

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Jan 3, 2025

Simple bump of thiserror to version 2. We already have it in our tree, and it requires no modification to our code.


This change is Reviewable

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


Cargo.toml line 125 at r1 (raw file):

env_logger = "0.10.0"
thiserror = "2"

Should we not specify minor version?

Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @Serock3)


Cargo.toml line 125 at r1 (raw file):

Previously, Serock3 (Sebastian Holmin) wrote…

Should we not specify minor version?

Done Yes, we should!

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 merged commit a5ce52c into main Jan 3, 2025
43 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the bump-thiserror branch January 3, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants