Fix clippy lints and enable clippy in the CI #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
force-pushed
the
fix-clippy-lints
branch
2 times, most recently
from
f7ecf31 to
a5b21b5
Compare
Serock3
approved these changes
May 29, 2024
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, 3 of 3 files at r4, 2 of 2 files at r5, 1 of 1 files at r6, 6 of 6 files at r7, 1 of 1 files at r8, 3 of 3 files at r10, 3 of 3 files at r11, 1 of 1 files at r12, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #89. This PR fixes everything
cargo clippyhad to complain about, and add it to the CI.This bumps the MSRV since
#[default]was stabilized in Rust 1.62. But that's 16 versions ago so no biggie.This change is