Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS(server): Add Documentation key to mumble-server unit #6637

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

diederikdehaas
Copy link
Contributor

Make it easy to view the man page by documenting it in its service unit file. Then it can be viewed via systemctl help mumble-server.service.

Checks

@diederikdehaas
Copy link
Contributor Author

I have a hard time seeing how my change could be the cause of the CI failures and certainly don't have an idea how to fix it.

This is the CI error:

[223/279] Performing build step for 'overlay_xcompile'
FAILED: overlay/overlay_xcompile-prefix/src/overlay_xcompile-stamp/overlay_xcompile-build D:/a/1/b/overlay/overlay_xcompile-prefix/src/overlay_xcompile-stamp/overlay_xcompile-build 
C:\Windows\system32\cmd.exe /C "cd /D D:\a\1\b\overlay\overlay_xcompile-prefix;D:\a\1\b\overlay\overlay_xcompile-prefix\src\overlay_xcompile-build && D:\a\1\s\overlay\scripts\build_overlay_xcompile.cmd -G Ninja -DCMAKE_TOOLCHAIN_FILE=C:/hostedtoolcache/windows/MumbleBuild/mumble_env.x64-windows-static-md-release.2024-07-22.9ad0398d8/scripts/buildsystems/vcpkg.cmake -DVCPKG_TARGET_TRIPLET=x86-windows-static-md-release -DMUMBLE_SOURCE_ROOT=D:/a/1/s -DMUMBLE_BINARY_DIR=D:/a/1/b -DCMAKE_BUILD_TYPE=Release -D3RDPARTY_DIR=D:/a/1/s/3rdparty -DCMAKE_C_COMPILER=cl.exe -DCMAKE_CXX_COMPILER=cl.exe -DBUILD_OVERLAY_XCOMPILE=ON -Dsymbols=ON -Dversion=1.6.0 D:/a/1/s/overlay && "C:\Program Files\CMake\bin\cmake.exe" -E touch D:/a/1/b/overlay/overlay_xcompile-prefix/src/overlay_xcompile-stamp/overlay_xcompile-build"
The filename, directory name, or volume label syntax is incorrect.

[224/279] Building RC object overlay\CMakeFiles\overlay.dir\mumble_ol.rc.res
[225/279] Building CXX object overlay\CMakeFiles\overlay.dir\opengl.cpp.obj
ninja: build stopped: subcommand failed.
##[error]Cmd.exe exited with code '1'.

@Hartmnt
Copy link
Member

Hartmnt commented Nov 29, 2024

@diederikdehaas Yup, this was an issue in our CI. Just rebase your branch against the current master and it should work again!

Make it easy to view the man page by documenting it in its service unit
file. Then it can be viewed via `systemctl help mumble-server.service`.
Copy link
Member

@Krzmbrzl Krzmbrzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hartmnt I'll leave it up to you whether or not this should be backported.

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Dec 2, 2024

💚 All backports created successfully

Status Branch Result
1.5.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Hartmnt added a commit that referenced this pull request Dec 2, 2024
@diederikdehaas diederikdehaas deleted the systemd-documentation branch December 2, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants