feat: implement method calls #577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
+ Coverage 87.61% 87.87% +0.25%
==========================================
Files 271 271
Lines 31453 31898 +445
==========================================
+ Hits 27559 28029 +470
+ Misses 3894 3869 -25 ☔ View full report in Codecov by Sentry. |
7 tasks
Wodann
reviewed
Dec 1, 2024
Wodann
reviewed
Dec 1, 2024
Wodann
requested changes
Dec 1, 2024
| } | ||
|
|
||
| /// Filter methods based on the specified lookup mode. | ||
| pub fn with_association_opt(self, association: Option<AssociationMode>) -> Self { |
There was a problem hiding this comment.
Doesn't it make more sense to have without_association, as the Some case is already covered by with_association?
| @@ -362,6 +403,8 @@ impl<'db> MethodResolutionCtx<'db> { | |||
| } | |||
| } | |||
|
|
|||
| // Check if the function | |||
| id: *expr, | ||
| found: receiver_ty, | ||
| }); | ||
| match self.lookup_field(receiver_ty.clone(), name) { |
| ) | ||
| .map_or_else(identity, Some); | ||
|
|
||
| // |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds syntax for method calls and infers return types and argument types.