-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing broken links to acm.org #19
Conversation
I would prefer to instead see a note indicating pay wall status, and/or an alternate copy linked on the theory that a restricted link is still better than none at all. |
@ahankinson There is still the DOI, that leeds to the download page. |
I agree with @ahankinson -- I'd rather see a notification of the pay wall than not see the link at all. |
Am I talking chinese? The links are broken and just return an error: |
You're right -- keeping broken links serves no purpose. But where are the broken links coming from? The entry for the item in the original, hand-coded bibliography was
so what's creating the Also, there appear to be a number of items missing from the dynamically generated bibliography compared with the original. For example --
is no longer present. |
@musicEnfanthen can you shed some light? And maybe add the missing items to the bibtex file? |
@rettinghaus Sorry for any misunderstanding but in your PR you didn't mention the links didn't work, you just mentioned that you removed links to PDFs behind pay walls. |
Sorry for any trouble and inconvenience. The links to the DLfM article pdfs were added by me (manually) to provide direct access to the pdf in case you are not paywalled. Before my PR, I had checked the links twice and had never encountered this error message which is shown now. At least for the two Early Music articles, I can confirm that the links are working, not broken. I don't have access now to the DLfM articles, but let me check on monday if the links are really broken or "just" restricted. Nonetheless, you are absolutely right, for links that are not broken, but behind paywall, we should use the @pe-ro I just double-checked the list again and can't see any items from the "hand-coded" version that are not in the dynamic one. Of course, the order of the entries has slightly changed: it is grouped by publication year now (bibbase default), not in alphabetical order. It is possible to switch the The item that you mentioned (Bohl, Kepper & Röwenstrunk in Tonkunst 2011) is indeed missing, and it would be good to add it. It seems, that it was already missing in the original list, at least I cannot find it in the older version(s). But maybe I am looking at the wrong place. Is there another old version that I am missing? |
@ahankinson Sorry, I thought the title "Removing broken links" would have said enough ;-) |
Some people consider pay walled links "broken". |
I added the "missing" article. We can re-add (working) links to pdfs later. |
@musicEnfanthen, I apologize -- I have a later version of the bibliography on my machine that didn't get transferred to the old WordPress site and, therefore, wasn't migrated to GitHub. It's less selective than the one on the website as it includes items that simply mention MEI in passing, are student work, or that, in a very small number of cases, aren't correct or flattering. Perhaps, however, we should provide access to this information, warts and all. With that in mind, I've attached my less selective (but not absolutely complete) Word version of the bibliography. |
@rettinghaus thanks for adding the missing article and catching the broken links. Just to finish up the open ends of the discussion: I just checked the DLfM links again and see the issue now: The pdf links are correct indeed, but they are working ONLY AFTER going to the article page with the download link and clicking on that link. I guess, some authorization stuff is added to the cache then, and afterwards the pdf link (re)opens without any error message. Knowing this, it really makes little sense to have the links (re)added, as you have to go first to the article page anyway. The pdf links for the two Early Music articles are working correct and one could re-add them with an appropriate note (something like: Available only by subsricption"?) @pe-ro Thank you for the information about the less selective version of the bibliography and sharing your Word file with further literature mentioning MEI. Let's continue this in #21 |
@musicEnfanthen is there a good way to provide the needed note to the pdf links? Personally I would say the DOI is enough as the article is just another click away. It's just a little less convenient for people with subscription. |
As this PR was closed before being fully resolved, how should we proceed? @rettinghaus ? |
moved unsolved discussion to #23 |
Removing broken links to acm.org
This removes links to pdf files behind paywalls. Also one doubled doi link is removed.