Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cast custom data #976

Merged
merged 9 commits into from
Aug 13, 2024
Merged

Conversation

cjpillsbury
Copy link
Contributor

@cjpillsbury cjpillsbury commented Aug 13, 2024

Also:

  • Ensures omitted storyboard tokens and thumbnail tokens don't cause errors.

Copy link

vercel bot commented Aug 13, 2024

@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 7:54pm
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 7:54pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 7:54pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 7:54pm
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 7:54pm

@@ -150,6 +151,8 @@
| `chapters` <sub><sup>Read only</sup></sub> | `Array<{ startTime: number; endTime?: number, value: string; }>` | The array of Chapters for the current media, added via `addChapters(chapters)`. | `[]` |
| `activeCuePoint` <sub><sup>Read only</sup></sub> | `{ startTime: number; endTime?: number, value: any; }` | The current active CuePoint, determined based on the player's `currentTime`. | `undefined` |
| `activeChapter` <sub><sup>Read only</sup></sub> | `{ startTime: number; endTime?: number, value: string; }` | The current active Chapter, determined based on the player's `currentTime`. | `undefined` |
| `castReceiver` | `string` (Receiver ID) | The app ID to use for a custom [Google cast receiver](https://developers.google.com/cast/docs/web_receiver/basic). If none is provided, the default receiver app will be used. | `undefined` |
| `castCustomData` | `object` (JSON-serializable) | [Custom Data](https://developers.google.com/cast/docs/reference/web_sender/chrome.cast.media.MediaInfo#customData) to send to your Google cast receiver on initial load. If none is provided, various Mux key/value pairs will be sent. | Mux-specific object |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure how to document the default value here, which is a bunch of mappings of mux player props to an object

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants