Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for customizing playback params #63

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Conversation

daytime-em
Copy link
Collaborator

No description provided.

@daytime-em daytime-em requested a review from a team as a code owner October 11, 2024 19:42
* A configurable example that uses the normal media3 player UI to play a video in the foreground from
* Mux Video, using a Playback ID
*
* You can configure the Activity via the UI
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. and soon a URL

# This is the 1st commit message:

Adding strings

# This is the commit message #2:

menu items

# This is the commit message #3:

min res

# This is the commit message #4:

Implement example menu

# This is the commit message #5:

wip

# This is the commit message #6:

wip

# This is the commit message #7:

more menu items

# This is the commit message #8:

resolution

# This is the commit message #9:

Add inputs for playback ID and tokens

# This is the commit message #10:

playback params

# This is the commit message #11:

Now we got one

# This is the commit message #12:

ok

# This is the commit message #13:

now we got it

# This is the commit message #14:

here we go

# This is the commit message #15:

now we got it

# This is the commit message #16:

got it

# This is the commit message #17:

Views

# This is the commit message #18:

scroll it

# This is the commit message #19:

cleanup on UI

# This is the commit message #20:

omg kotlin i love scpoe functions nest nest nest

# This is the commit message #21:

Now we got it working basically

# This is the commit message #22:

yeah

# This is the commit message #23:

OK

# This is the commit message #24:

State methods

# This is the commit message #25:

Done

# This is the commit message #26:

ok here we go

# This is the commit message #27:

progress

# This is the commit message #28:

remove redundant Activities

# This is the commit message #29:

no intent parsing yet

# This is the commit message #30:

did it

# This is the commit message #31:

up

# This is the commit message #32:

Rename

# This is the commit message #33:

Ok here we go

# This is the commit message #34:

example kdoc

# This is the commit message #35:

add very-basic example back

# This is the commit message #36:

Added that

# This is the commit message #37:

meh, don't do the desc
@daytime-em daytime-em force-pushed the test/playback-params-ui branch from b49b204 to ba7045c Compare October 11, 2024 19:53
Copy link

@andrewjl-mux andrewjl-mux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@daytime-em daytime-em merged commit 2e4871f into main Oct 11, 2024
1 check passed
@daytime-em daytime-em deleted the test/playback-params-ui branch October 11, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants