-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI for customizing playback params #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daytime-em
commented
Oct 11, 2024
* A configurable example that uses the normal media3 player UI to play a video in the foreground from | ||
* Mux Video, using a Playback ID | ||
* | ||
* You can configure the Activity via the UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. and soon a URL
# This is the 1st commit message: Adding strings # This is the commit message #2: menu items # This is the commit message #3: min res # This is the commit message #4: Implement example menu # This is the commit message #5: wip # This is the commit message #6: wip # This is the commit message #7: more menu items # This is the commit message #8: resolution # This is the commit message #9: Add inputs for playback ID and tokens # This is the commit message #10: playback params # This is the commit message #11: Now we got one # This is the commit message #12: ok # This is the commit message #13: now we got it # This is the commit message #14: here we go # This is the commit message #15: now we got it # This is the commit message #16: got it # This is the commit message #17: Views # This is the commit message #18: scroll it # This is the commit message #19: cleanup on UI # This is the commit message #20: omg kotlin i love scpoe functions nest nest nest # This is the commit message #21: Now we got it working basically # This is the commit message #22: yeah # This is the commit message #23: OK # This is the commit message #24: State methods # This is the commit message #25: Done # This is the commit message #26: ok here we go # This is the commit message #27: progress # This is the commit message #28: remove redundant Activities # This is the commit message #29: no intent parsing yet # This is the commit message #30: did it # This is the commit message #31: up # This is the commit message #32: Rename # This is the commit message #33: Ok here we go # This is the commit message #34: example kdoc # This is the commit message #35: add very-basic example back # This is the commit message #36: Added that # This is the commit message #37: meh, don't do the desc
daytime-em
force-pushed
the
test/playback-params-ui
branch
from
October 11, 2024 19:53
b49b204
to
ba7045c
Compare
andrewjl-mux
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cjpillsbury
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.