fix: dropped frames not reported #74
Conversation
| @@ -360,6 +366,9 @@ open class MuxStateCollector( | |||
| @Suppress("unused") | |||
| fun incrementDroppedFrames(droppedFrames: Int) { | |||
| this.droppedFrames += droppedFrames | |||
| muxStats.setDroppedFramesCount(this.droppedFrames.toLong()) | |||
| // note - in the current implementation, we rely on a subsequent playback event to send this. | |||
There was a problem hiding this comment.
Did we always rely on a subsequent playback event to send this?
There was a problem hiding this comment.
Separate question. Out of curiosity. How does this cross-cut with beacon flushing where only some playback events trigger a flush and some others do not?
There was a problem hiding this comment.
Did we always rely on a subsequent playback event to send this?
Yeah as far as I know the ExoPlayer SDK worked the same way.
Separate question. Out of curiosity. How does this cross-cut with beacon flushing where only some playback events trigger a flush and some others do not?
Theoretically if we had some kind of droppedframes event, it wouldn't have to be a flushEvent, so wouldn't necessarily cause beacons. We don't have an event for it though. We could send something, but i see no reason to rock the boat tbh
## Improvements * fix: dropped frames not reported (#74) Co-authored-by: Emily Dixon <[email protected]> Co-authored-by: GitHub <[email protected]>
No description provided.