Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Defer content rendition changes during ads #76

Merged
merged 32 commits into from
Dec 11, 2024

Conversation

daytime-em
Copy link
Collaborator

No description provided.

@daytime-em daytime-em requested a review from a team as a code owner November 27, 2024 20:33
@daytime-em daytime-em changed the base branch from main to releases/v1.4.5 November 28, 2024 01:43
Copy link

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor ask on the tests. Otherwise, LGTM!

@daytime-em
Copy link
Collaborator Author

@cjpillsbury I updated the tests to cover subsequent renditionchange events

@daytime-em daytime-em merged commit becd78d into releases/v1.4.5 Dec 11, 2024
1 check passed
@daytime-em daytime-em deleted the feat/defer-renditionchange-during-events branch December 11, 2024 17:17
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
daytime-em added a commit that referenced this pull request Dec 13, 2024
## Fixes
* fix: Defer content rendition changes during ads  (#76)

### Internal lib updates
* update `stats.muxcore` to v8.1.4



Co-authored-by: Emily Dixon <[email protected]>
Co-authored-by: GitHub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants