-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Vagrant development boxes #7503
Conversation
Need to think about this a bit. It looks like it may be possible to use VirtualBox on M1 soon. I'd like to both simplify what we maintain, but also get back to a place where we develop with dev/prod parity, which we're not really doing right now, but were much closer with the Vagrant setup. Also need to consider future mySociety infrastructure direction. |
Looks like Rails is going to start generating a |
In my recent install script changes I have been using UTM on my M1 mac, with the https://mac.getutm.app/gallery/debian-11-xfce sample image. Following https://alaveteli.org/docs/installing/script/ with some minor changes. Login as the
The install will fail with:
So I become the diff --git a/config/packages.generic b/config/packages.generic
index c57c7f05a..cb7c2bf55 100644
--- a/config/packages.generic
+++ b/config/packages.generic
@@ -31,6 +31,6 @@ ttf-bitstream-vera
unrtf
unzip
uuid-dev
-wkhtmltox
+wkhtmltopdf
wv
xapian-tools Re-running the install script might error with:
If so, change the install script by: diff --git a/bin/install-site.sh b/bin/install-site.sh
index a231959..a2addf6 100755
--- a/bin/install-site.sh
+++ b/bin/install-site.sh
@@ -668,6 +668,6 @@ add_unix_user
update_apt_sources
# Remove one crippling package, if it's installed:
apt-get -qq remove -y --purge apt-xapian-index >/dev/null || true
-clone_or_update_repository
+# clone_or_update_repository
chown -R "$UNIX_USER"."$UNIX_USER" "$DIRECTORY"
run_site_specific_script
And now re-running the install script again should finally now work. Next, we need to disable the default nginx site The site should be accessible from |
da784b1
to
467f33a
Compare
The above |
With the move to BUSL I think we should get this merged. |
We now recommend using Docker for development instead.
467f33a
to
3b898b6
Compare
Agree! 🧹 |
What does this do?
Drop Vagrant development boxes
Why was this needed?
We are now using Docker for development instead.
Notes to reviewer
@garethrees are you okay with remove the Vagrantfile? As its of no use on M1 Macs I see no reason to keep it around as we can't test it. Going forward we need a plan on how to test OSs.