Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update front page text and button colour #625

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

dracos
Copy link
Member

@dracos dracos commented Dec 12, 2024

Also remove any IE6-8 stuff.

@dracos dracos force-pushed the fd-4903-text-button-change branch 4 times, most recently from da15bb7 to 26b6b5b Compare December 12, 2024 21:56
@dracos dracos requested a review from gbp December 13, 2024 10:05
@dracos
Copy link
Member Author

dracos commented Dec 13, 2024

Hi @gbp If you had a moment to look at this, thanks - the actual changes are to text and button colour, I removed any IE6-8 stuff, and then had to tweak a few things in the action/gems to get robocop to run/pass, which seems to have worked, but I don't know if I should have done something different there.

@gbp gbp force-pushed the fd-4903-text-button-change branch from 26b6b5b to cda4ab8 Compare December 17, 2024 08:19
Copy link
Member

@gbp gbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have merged the gem and GH action change separately in a separate PR and rebased.

@gbp gbp merged commit 6af62f4 into master Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants