[ExcelAnalyzer] Patch RequestMailer.new_response #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't send no response notifications while we're processing attachments, instead wait until the ExcelAnalyzer and PIIBadger scripts have run to determine if the attachments in the response have been hidden on not. Fixes mysociety/whatdotheyknow-private#315
gbp
force-pushed
the
excel-analyzer-new-response-notifications
branch
from
f1cc226 to
fbb8d83
Compare
|
|
gbp
added a commit
to mysociety/alaveteli
that referenced
this pull request
Oct 21, 2024
Ensure incoming message isn't reparsed. This will break with this mocked data. Needed for WDTK theme. See: mysociety/whatdotheyknow-theme#1902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes https://github.com/mysociety/whatdotheyknow-private/issues/315
What does this do?
Patch RequestMailer.new_response
Why was this needed?
Don't send no response notifications while we're processing attachments, instead wait until the ExcelAnalyzer and PIIBadger scripts have run to determine if the attachments in the response have been hidden on not.