Replaced mid_grey with dark_grey #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text using the $color_mid_grey variable wasn't passing the contrast test(3.11), even against #fff. By using $color_dark_grey instead the contrast test is passing with 5.32. Still gets a muted effect.
gbp
requested changes
Aug 14, 2024
| @@ -1217,7 +1217,7 @@ p.locale-list-trigger { | |||
| border-bottom: none; | |||
| background-color: rgba(0,0,0,0.1); | |||
| @include respond-min($main_menu-mobile_menu_cutoff) { | |||
| background-color: darken($color_mid_grey, 10%); | |||
| background-color: darken($color_dark_grey, 10%); | |||
There was a problem hiding this comment.
This breaks the hover effect:
locale-hover.mov
There was a problem hiding this comment.
@gbp Thanks for the video. I just added a fixup that should fix the issue. I kept the mid-grey but increased the darkening factor to 15% now the contrast ratio is at 5.33. However I did it for the default state and not the hover one. The default one was failing the contrast test.
| @@ -977,7 +977,7 @@ div.correspondence { | |||
|
|
|||
| font-weight: 600; | |||
| strong { | |||
| color: $color_mid_grey; | |||
| color: $color_dark_grey; | |||
| @@ -1888,7 +1888,7 @@ dd { | |||
| } | |||
|
|
|||
| .no-entries { | |||
| color: $color_mid_grey; | |||
| color: $color_dark_grey; | |||
gbp
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
While working on a blog post I noticed the contrast test of anything using
color_mid_greyagainst a light background was failing the contrast test(3.11). No issue has been formally created.What does this do?
Text using the
$color_mid_greyvariable wasn't passing the contrast test(3.11), even against#fff. By using$color_dark_greythe contrast test is passing with 5.32. Still gets a muted effect.Screenshots
Notes to reviewer