Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featuring pip installation #20

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

claudiaelizabete
Copy link

Overview

  • This PR introduces siyi_sdk as a Python package with a setup.py file, enabling installation via pip.

What was added/changed in this update

  • Add siyi_sdk module
  • Add imutils and opencv2 to dependencies

@mzahana
Copy link
Owner

mzahana commented Dec 3, 2024

Thanks @claudiaelizabete for the PR. However, I can not accept it as it is redirecting the pip installation to another repository, not this one. Additionally, it seems that in the setup.py you are not using the correct author and contact information, which is not conforming with the copy rights.

@claudiaelizabete
Copy link
Author

Thanks @claudiaelizabete for the PR. However, I can not accept it as it is redirecting the pip installation to another repository, not this one. Additionally, it seems that in the setup.py you are not using the correct author and contact information, which is not conforming with the copy rights.

Thank you for the quick response! I have updated the setup.py and the README with the correct information.

@mzahana
Copy link
Owner

mzahana commented Dec 4, 2024

Thanks for the updates.
I still have to test this PR.
I also think there are missing dependencies such as Gstreamer and ffmpeg.

@claudiaelizabete
Copy link
Author

Thank you for the comment. Since Gstreamer and ffmpeg are apt packages, setuptools does not install them, so I left them out of setup.py. I added ffmpeg-python to the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants