Fix warnings #191
Open
Fix warnings #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambertjamesd
commented
Jan 24, 2021
| @@ -101,29 +101,6 @@ cen64_align(static const uint16_t sll_l2b_keys[16][8], CACHE_LINE_SIZE) = { | |||
| {0x8080, 0x8080, 0x8080, 0x8080, 0x8080, 0x8080, 0x8080, 0x0180}, | |||
| }; | |||
|
|
|||
| // Shift right LUT; shifts in zeros from the left, one byte at a time. | |||
| cen64_align(static const uint16_t srl_b2l_keys[16][8], CACHE_LINE_SIZE) = { | |||
There was a problem hiding this comment.
My biggest hesitation to merging this PR is this table may be useful in the future even though it is unused now. There may be a better way to ignore the warning that this is unused.
|
Are there any other changes needed before this can be merged? It would be nice to not have so many warnings when compiling code. |
|
@lambertjamesd I'd love to get this merged. Would you please rebase it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through and fixed any warnings on the gcc build