Remove unused includes (#4349)

* Remove unused includes * Convert boost::make_shared to std::make_shared * Remove needless boost/filesystem.hpp * Remove needless flatbuffers forward class declaration --------- Co-authored-by: Dimitrios Siganos <[email protected]>
nanocurrency · Jan 10, 2024 · d0418ba · d0418ba
1 parent a7d2b4c
commit d0418ba
Show file tree

Hide file tree

Showing 36 changed files with 1 addition and 60 deletions.
diff --git a/nano/core_test/confirmation_height.cpp b/nano/core_test/confirmation_height.cpp
@@ -5,8 +5,6 @@
 
 #include <gtest/gtest.h>
 
-#include <boost/format.hpp>
-
 using namespace std::chrono_literals;
 
 namespace

diff --git a/nano/core_test/logger.cpp b/nano/core_test/logger.cpp
@@ -5,8 +5,6 @@
 
 #include <gtest/gtest.h>
 
-#include <boost/filesystem.hpp>
-
 #include <chrono>
 #include <regex>
 #include <thread>

diff --git a/nano/core_test/message_deserializer.cpp b/nano/core_test/message_deserializer.cpp
@@ -4,8 +4,6 @@
 
 #include <gtest/gtest.h>
 
-#include <boost/none.hpp>
-
 #include <memory>
 #include <vector>
 

diff --git a/nano/core_test/node.cpp b/nano/core_test/node.cpp
@@ -12,10 +12,6 @@
 
 #include <gtest/gtest.h>
 
-#include <boost/filesystem.hpp>
-#include <boost/make_shared.hpp>
-#include <boost/optional.hpp>
-
 #include <fstream>
 #include <numeric>
 
@@ -69,7 +65,7 @@ TEST (node, work_generate)
 TEST (node, block_store_path_failure)
 {
 	nano::test::system system;
-	auto service (boost::make_shared<boost::asio::io_context> ());
+	auto service (std::make_shared<boost::asio::io_context> ());
 	auto path (nano::unique_path ());
 	nano::logging logging;
 	logging.init (path);

diff --git a/nano/core_test/signal_manager.cpp b/nano/core_test/signal_manager.cpp
@@ -15,8 +15,6 @@
 
 #include <gtest/gtest.h>
 
-#include <boost/format.hpp>
-
 #include <csignal>
 #include <iostream>
 #include <thread>

diff --git a/nano/core_test/socket.cpp b/nano/core_test/socket.cpp
@@ -1,7 +1,6 @@
 #include <nano/boost/asio/ip/address_v6.hpp>
 #include <nano/boost/asio/ip/network_v6.hpp>
 #include <nano/lib/thread_runner.hpp>
-#include <nano/lib/threading.hpp>
 #include <nano/node/transport/socket.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>

diff --git a/nano/core_test/wallet.cpp b/nano/core_test/wallet.cpp
@@ -1,14 +1,11 @@
 #include <nano/crypto_lib/random_pool.hpp>
 #include <nano/lib/thread_runner.hpp>
-#include <nano/lib/threading.hpp>
 #include <nano/store/lmdb/wallet_value.hpp>
 #include <nano/test_common/system.hpp>
 #include <nano/test_common/testutil.hpp>
 
 #include <gtest/gtest.h>
 
-#include <boost/filesystem.hpp>
-
 using namespace std::chrono_literals;
 unsigned constexpr nano::wallet_store::version_current;
 

diff --git a/nano/node/active_transactions.hpp b/nano/node/active_transactions.hpp
@@ -12,7 +12,6 @@
 #include <boost/multi_index/sequenced_index.hpp>
 #include <boost/multi_index_container.hpp>
 
-#include <atomic>
 #include <condition_variable>
 #include <deque>
 #include <memory>

diff --git a/nano/node/backlog_population.hpp b/nano/node/backlog_population.hpp
@@ -5,7 +5,6 @@
 #include <nano/lib/observer_set.hpp>
 #include <nano/secure/common.hpp>
 
-#include <atomic>
 #include <condition_variable>
 #include <thread>
 

diff --git a/nano/node/bootstrap/bootstrap.cpp b/nano/node/bootstrap/bootstrap.cpp
@@ -1,4 +1,3 @@
-#include <nano/lib/threading.hpp>
 #include <nano/node/bootstrap/bootstrap.hpp>
 #include <nano/node/bootstrap/bootstrap_lazy.hpp>
 #include <nano/node/bootstrap/bootstrap_legacy.hpp>

diff --git a/nano/node/bootstrap/bootstrap.hpp b/nano/node/bootstrap/bootstrap.hpp
@@ -10,7 +10,6 @@
 #include <boost/thread/thread.hpp>
 
 #include <atomic>
-#include <queue>
 
 namespace mi = boost::multi_index;
 

diff --git a/nano/node/bootstrap/bootstrap_frontier.hpp b/nano/node/bootstrap/bootstrap_frontier.hpp
@@ -1,7 +1,5 @@
 #pragma once
 
-#include <nano/node/common.hpp>
-
 #include <deque>
 #include <future>
 

diff --git a/nano/node/bootstrap_ascending/common.hpp b/nano/node/bootstrap_ascending/common.hpp
@@ -2,8 +2,6 @@
 
 #include <nano/crypto_lib/random_pool.hpp>
 
-#include <cstdlib>
-
 namespace nano::bootstrap_ascending
 {
 using id_t = uint64_t;

diff --git a/nano/node/bootstrap_ascending/peer_scoring.hpp b/nano/node/bootstrap_ascending/peer_scoring.hpp
@@ -1,7 +1,5 @@
 #pragma once
 
-#include <nano/node/common.hpp>
-
 #include <boost/multi_index/hashed_index.hpp>
 #include <boost/multi_index/member.hpp>
 #include <boost/multi_index/ordered_index.hpp>

diff --git a/nano/node/election.hpp b/nano/node/election.hpp
@@ -7,7 +7,6 @@
 #include <atomic>
 #include <chrono>
 #include <memory>
-#include <unordered_set>
 
 namespace nano
 {

diff --git a/nano/node/gap_cache.cpp b/nano/node/gap_cache.cpp
@@ -1,6 +1,5 @@
 #include <nano/node/gap_cache.hpp>
 #include <nano/node/node.hpp>
-#include <nano/store/component.hpp>
 
 #include <boost/format.hpp>
 

diff --git a/nano/node/ipc/ipc_server.hpp b/nano/node/ipc/ipc_server.hpp
@@ -1,6 +1,5 @@
 #pragma once
 
-#include <nano/ipc_flatbuffers_lib/generated/flatbuffers/nanoapi_generated.h>
 #include <nano/lib/errors.hpp>
 #include <nano/lib/ipc.hpp>
 #include <nano/node/ipc/ipc_access_config.hpp>
@@ -10,10 +9,6 @@
 #include <atomic>
 #include <memory>
 
-namespace flatbuffers
-{
-class Parser;
-}
 namespace nano
 {
 class node;

diff --git a/nano/node/messages.hpp b/nano/node/messages.hpp
@@ -5,7 +5,6 @@
 #include <nano/lib/config.hpp>
 #include <nano/lib/errors.hpp>
 #include <nano/lib/jsonconfig.hpp>
-#include <nano/lib/memory.hpp>
 #include <nano/lib/numbers.hpp>
 #include <nano/lib/stats_enums.hpp>
 #include <nano/lib/stream.hpp>

diff --git a/nano/node/node.cpp b/nano/node/node.cpp
@@ -1,5 +1,4 @@
 #include <nano/lib/stream.hpp>
-#include <nano/lib/threading.hpp>
 #include <nano/lib/tomlconfig.hpp>
 #include <nano/lib/utility.hpp>
 #include <nano/node/common.hpp>

diff --git a/nano/node/online_reps.hpp b/nano/node/online_reps.hpp
@@ -2,7 +2,6 @@
 
 #include <nano/lib/numbers.hpp>
 #include <nano/lib/utility.hpp>
-#include <nano/secure/common.hpp>
 
 #include <boost/multi_index/hashed_index.hpp>
 #include <boost/multi_index/member.hpp>

diff --git a/nano/node/request_aggregator.cpp b/nano/node/request_aggregator.cpp
@@ -1,5 +1,4 @@
 #include <nano/lib/stats.hpp>
-#include <nano/lib/threading.hpp>
 #include <nano/node/active_transactions.hpp>
 #include <nano/node/common.hpp>
 #include <nano/node/network.hpp>

diff --git a/nano/node/scheduler/component.hpp b/nano/node/scheduler/component.hpp
@@ -1,7 +1,5 @@
 #pragma once
 
-#include <nano/lib/locks.hpp>
-
 #include <memory>
 #include <string>
 

diff --git a/nano/node/scheduler/hinted.hpp b/nano/node/scheduler/hinted.hpp
@@ -12,7 +12,6 @@
 #include <chrono>
 #include <condition_variable>
 #include <thread>
-#include <unordered_map>
 
 namespace mi = boost::multi_index;
 

diff --git a/nano/node/transport/socket.cpp b/nano/node/transport/socket.cpp
@@ -1,5 +1,4 @@
 #include <nano/boost/asio/bind_executor.hpp>
-#include <nano/boost/asio/ip/address_v6.hpp>
 #include <nano/boost/asio/read.hpp>
 #include <nano/node/node.hpp>
 #include <nano/node/transport/socket.hpp>

diff --git a/nano/node/transport/transport.cpp b/nano/node/transport/transport.cpp
@@ -5,7 +5,6 @@
 #include <boost/asio/ip/address.hpp>
 #include <boost/asio/ip/address_v4.hpp>
 #include <boost/asio/ip/address_v6.hpp>
-#include <boost/format.hpp>
 
 nano::endpoint nano::transport::map_endpoint_to_v6 (nano::endpoint const & endpoint_a)
 {

diff --git a/nano/node/vote_cache.hpp b/nano/node/vote_cache.hpp
@@ -8,7 +8,6 @@
 
 #include <boost/multi_index/hashed_index.hpp>
 #include <boost/multi_index/mem_fun.hpp>
-#include <boost/multi_index/member.hpp>
 #include <boost/multi_index/ordered_index.hpp>
 #include <boost/multi_index/sequenced_index.hpp>
 #include <boost/multi_index_container.hpp>

diff --git a/nano/node/vote_processor.cpp b/nano/node/vote_processor.cpp
@@ -1,6 +1,5 @@
 #include <nano/lib/logger_mt.hpp>
 #include <nano/lib/stats.hpp>
-#include <nano/lib/threading.hpp>
 #include <nano/lib/timer.hpp>
 #include <nano/node/active_transactions.hpp>
 #include <nano/node/node_observers.hpp>

diff --git a/nano/node/voting.cpp b/nano/node/voting.cpp
@@ -1,5 +1,4 @@
 #include <nano/lib/stats.hpp>
-#include <nano/lib/threading.hpp>
 #include <nano/lib/utility.hpp>
 #include <nano/node/network.hpp>
 #include <nano/node/nodeconfig.hpp>

diff --git a/nano/node/websocket.cpp b/nano/node/websocket.cpp
@@ -5,7 +5,6 @@
 #include <nano/lib/work.hpp>
 #include <nano/node/node_observers.hpp>
 #include <nano/node/transport/channel.hpp>
-#include <nano/node/transport/transport.hpp>
 #include <nano/node/wallet.hpp>
 #include <nano/node/websocket.hpp>
 

diff --git a/nano/secure/network_filter.hpp b/nano/secure/network_filter.hpp
@@ -3,8 +3,6 @@
 
 #include <nano/lib/numbers.hpp>
 
-#include <mutex>
-
 #include <cryptopp/seckey.h>
 #include <cryptopp/siphash.h>
 

diff --git a/nano/slow_test/bootstrap.cpp b/nano/slow_test/bootstrap.cpp
@@ -14,9 +14,6 @@
 
 #include <gtest/gtest.h>
 
-#include <boost/format.hpp>
-
-#include <map>
 #include <thread>
 
 using namespace std::chrono_literals;

diff --git a/nano/slow_test/node.cpp b/nano/slow_test/node.cpp
@@ -1,6 +1,5 @@
 #include <nano/crypto_lib/random_pool.hpp>
 #include <nano/lib/thread_runner.hpp>
-#include <nano/lib/threading.hpp>
 #include <nano/node/election.hpp>
 #include <nano/node/make_store.hpp>
 #include <nano/node/scheduler/component.hpp>
@@ -17,7 +16,6 @@
 #include <boost/format.hpp>
 #include <boost/unordered_set.hpp>
 
-#include <numeric>
 #include <random>
 
 using namespace std::chrono_literals;

diff --git a/nano/test_common/ledger.hpp b/nano/test_common/ledger.hpp
@@ -2,7 +2,6 @@
 
 #include <nano/lib/logger_mt.hpp>
 #include <nano/lib/stats.hpp>
-#include <nano/node/common.hpp>
 #include <nano/secure/ledger.hpp>
 
 namespace nano

diff --git a/nano/test_common/rate_observer.hpp b/nano/test_common/rate_observer.hpp
@@ -6,7 +6,6 @@
 #include <chrono>
 #include <string>
 #include <thread>
-#include <utility>
 #include <vector>
 
 namespace nano::test

diff --git a/nano/test_common/telemetry.hpp b/nano/test_common/telemetry.hpp
@@ -1,7 +1,5 @@
 #pragma once
 
-#include <cstdint>
-
 namespace nano
 {
 class node;

diff --git a/nano/test_common/testutil.hpp b/nano/test_common/testutil.hpp
@@ -1,10 +1,8 @@
 #pragma once
 
-#include <nano/lib/errors.hpp>
 #include <nano/lib/locks.hpp>
 #include <nano/lib/timer.hpp>
 #include <nano/node/transport/channel.hpp>
-#include <nano/node/transport/transport.hpp>
 
 #include <gtest/gtest.h>