Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error Causing Duplicate Responses When Token Expired #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krkeegan
Copy link

If the access token expired after the first page of a multiple page response had been retreived, the previous code would refresh the access token, but start the request over again from page 1. This would lead to duplicate data appearing in the response.

It was a rare bug that would require exact timing to occur.

This code stores the page request token, and reuses it after the access token is refreshed to avoid any duplicate data.

krkeegan added 2 commits May 17, 2024 08:40
If the access token expired after the first page of a multiple
page response had been retreived, the previous code would
refresh the access token, but start the request over again from
page 1.  This would lead to duplicate data appearing in the
response.

It was a rare bug that would require exact timing to occur.

This code stores the page request token, and reuses it after the
access token is refreshed to avoid any duplicate data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant