-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Healpix doc #2498
base: main
Are you sure you want to change the base?
Healpix doc #2498
Conversation
Please fix the following build error:
The cause of this error is the imports in your Python sample code, which is enclosed in triple quotes ('''). Triple quotes don't do anything in Markdown, so the MDX parser is attempting to interpret those lines as JavaScript imports. The correct delimiter for a code block in Markdown is triple backticks (```). |
Is there a reason why we still have this marked as a draft? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2498 +/- ##
=====================================
Coverage 6.06% 6.06%
=====================================
Files 171 171
Lines 4334 4334
Branches 476 476
=====================================
Hits 263 263
Misses 4069 4069
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Following #2035, two points are still incomplete: |
What happened to the documentation on including healpix maps in producing notices? |
If I understand it correctly it should be similar as Then consumer needs document to read it from the above doc. |
For attaching the fits file, it's mentioned in PR: https://github.com/nasa-gcn/gcn.nasa.gov/pull/2669/files Is this sufficient? |
e86f307
to
30f6292
Compare
Add a list of categories of sample codes at the top linking to the appropriate headings. |
d7e1ec0
to
b13d14f
Compare
Co-authored-by: Judy Racusin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is starting to look good. Just some typos and code errors.
hpx, header = hp.read_map('*.fits.gz,0', h=True) | ||
|
||
# Plotting a Mollweide-projection all-sky map | ||
np.mollview(hpx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np.mollview(hpx) | |
hp.mollview(hpx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if you actually want the plot to appear, then you have to add:
from matplotlib import pyplot as plt
plt.show()
xyz = [[-0.5, -0.4, -0.5], | ||
[-0.4, -0.4, -0.6], | ||
[-0.6, -0.3, -0.6], | ||
[-0.7 , -0.4, -0.5]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not unit vectors.
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
Description
Add document for parsing and using HEALPix docs
Explaining what it represents, how one can understand a skymap
Resolves: #2035