Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new devices to main README list #24

Open
JosephBowkett opened this issue Apr 4, 2022 · 3 comments
Open

Add new devices to main README list #24

JosephBowkett opened this issue Apr 4, 2022 · 3 comments
Assignees

Comments

@JosephBowkett
Copy link
Collaborator

We'll want to add the newly created drivers for EL3162 and EL4102 to the main readme.

As an aside, it might also help to add a brief blurb to each of the beckhoff devices in the main readme so casual readers can see the types of devices already supported rather than having to google each of the device names to see what they are.

@JosephBowkett
Copy link
Collaborator Author

Realizing I must have missed this on the original pull request review, my bad!

@d-loret
Copy link
Contributor

d-loret commented Apr 4, 2022

@JosephBowkett, the Fastcat PRs of each device add entries for them in the Fastcat Readme.

I didn't add them to the "Supported Devices" section in jsd/README.md because I do not know which release they would belong to. @alex-brinkman, any thoughts?

@JosephBowkett
Copy link
Collaborator Author

Ah right, the release they belong to is v1.6.0 which you can see based on the tag created when the pull request was accepted: https://github.com/nasa-jpl/jsd/releases

This was a useful bump to remind me that the fastcat PRs are still sitting there awaiting review... I'll look at them today.

Would you mind adding in the new devices and their respective version to the main JSD readme? Bonus points if you can include a new column for the Beckhoff devices and a couple of words on each one to describe what they are, though good point that the fastcat readme already includes this to some extent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants