CMR-9502: Has-granules-map cache to redis #2058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isja17
approved these changes
Feb 15, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2058 +/- ##
===========================================
- Coverage 58.12% 28.00% -30.13%
===========================================
Files 1042 1042
Lines 69529 69539 +10
Branches 1950 1176 -774
===========================================
- Hits 40413 19472 -20941
- Misses 27280 48893 +21613
+ Partials 1836 1174 -662 ☔ View full report in Codecov by Sentry. |
jceaser
reviewed
Mar 1, 2024
| @@ -35,6 +35,7 @@ | |||
| [cmr.metadata-db.config :as mdb-config] | |||
| [cmr.metadata-db.system :as mdb-system] | |||
| [cmr.metadata-db.services.util :as mdb-util] | |||
| [cmr.search.services.query-execution.has-granules-results-feature :as has-granules-results-feature] | |||
There was a problem hiding this comment.
you could say has-gran-rslt-feat, it's a bit long, but I don't mind either way. I love how people use longer names these days, but still remember fondly when you could shorting things up
jceaser
reviewed
Mar 1, 2024
| @@ -46,6 +46,12 @@ | |||
| (fn [concept-type query] | |||
| [concept-type (qm/base-result-format query)])) | |||
|
|
|||
| (defmethod concept-type+result-format->fields [:granule :xml] | |||
There was a problem hiding this comment.
I have not seen a + sign in a function name in our code base, have you seen another function do this? Obviously you can do it, but it stands out and I wonder what other developers think.
jceaser
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: THIS PR IS ON HOLD UNTIL UNBLOCKED BY REDIS FIXES. WILL WORK ON NEXT PI 24.2.0