Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10141-1: Fixing broken build #2189

Merged
merged 2 commits into from
Nov 12, 2024
Merged

CMR-10141-1: Fixing broken build #2189

merged 2 commits into from
Nov 12, 2024

Conversation

eereiter
Copy link
Contributor

Overview

What is the feature/fix?

Fixing broken build

What is the Solution?

Fixing broken build

What areas of the application does this impact?

Subscription

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@eereiter eereiter merged commit 6a7e069 into master Nov 12, 2024
6 checks passed
@eereiter eereiter deleted the CMR-10141-1 branch November 12, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants