Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10283: Fix styling inconsistencies from using the latest cmr-prev… #2199

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

eudoroolivares2016
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 commented Dec 17, 2024

Overview

What is the feature/fix?

The metadata preview version was updated resulting in styling inconsistencies because the CMR landing pages use both EUI and the metadata-preview plugin

What is the Solution?

Within those CMR landing pages I'm overriding some styling so that it looks more like the expected output from https://access.sit.earthdata.nasa.gov/ this is a somewhat temporary stopgap because the long-term fix is to pull out repeated styling from MMT, edsc-meatdata-plugin, and eventually Earthdata Search into an updated styling library so that we can consistently do this across the apps. For now though UX is degraded because titles are not clear, button text is miscolored, and the table formatting looks inconsistent because of borders. This PR is a hotfix to those things

What areas of the application does this impact?

Attachments

Current issues:
image
image
image

Local Fixes:
image
image

Build Result (Probably not necessary since this code is really splintered off from CMR core)
image

The CMR landing pages (.html endpoints) for collections, granules, tools, and services

Checklist

  • [N/A] I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • [N/A ] New and existing unit and int tests pass locally and remotely
  • [N/A] clj-kondo has been run locally and all errors corrected
  • [N/A] I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ N/A] I have made corresponding changes to the documentation
  • [N/A] My changes generate no new warnings
  • [N/A] I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@@ -11,6 +11,19 @@
<div id="metadata-preview">
<p>Fetching Tool...</p>
</div>
<!-- TODO we need to update a new version of EUI compliant with bootstrap-5 fix styling in the meantime -->
<style>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres an existing Warning: Failed prop type: Invalid prop tool.lastUpdatedDateof typestringsupplied toBC, expected object. we should fix on the edsc-metadata-plugin

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.30%. Comparing base (b10ce3f) to head (05e3a72).

❗ There is a different number of reports uploaded between BASE (b10ce3f) and HEAD (05e3a72). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b10ce3f) HEAD (05e3a72)
5 3
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2199       +/-   ##
===========================================
- Coverage   58.22%   29.30%   -28.93%     
===========================================
  Files        1056      996       -60     
  Lines       71012    67658     -3354     
  Branches     2024     1213      -811     
===========================================
- Hits        41350    19828    -21522     
- Misses      27772    46690    +18918     
+ Partials     1890     1140      -750     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eudoroolivares2016 eudoroolivares2016 marked this pull request as ready for review December 18, 2024 16:09
@eudoroolivares2016 eudoroolivares2016 merged commit fe3fde2 into master Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants