Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10285: Adding check before subscribing to AWS that the subscription is an ingest subscription. #2200

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

eereiter
Copy link
Contributor

Overview

What is the feature/fix?

Added a check if the subscription is an ingest subscription, only then add the subscription.

What is the Solution?

Added a check if the subscription is an ingest subscription, only then add the subscription.

What areas of the application does this impact?

Subscriptions

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@eereiter eereiter merged commit b10ce3f into master Dec 18, 2024
6 checks passed
@eereiter eereiter deleted the CMR-10285 branch December 18, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants