Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10252: adding a command line interface for the find-lr function #2201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jceaser
Copy link
Contributor

@jceaser jceaser commented Dec 20, 2024

Overview

new command line application added to spatial-lib

What is the feature/fix?

A command line interface to the find-lr function has been added to allow for external tools to use the exact same calculation that CMR uses to calculate the Largest internal Rectangle (LR).

You can have your data returned in two ways, 1) GEOJSON friendly JSON, 2) WKT.

What is the Solution?

  • main function was added
  • a very large polygon was added to a text file in the resource directory for use as a test

What areas of the application does this impact?

No interfaces or other functions should be impacted as this is an additional functionality only used on the command line.

Checklist

  • [-] I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [-] I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@jceaser jceaser requested review from zimzoom and cgokey December 20, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant