Skip to content

Commit

Permalink
DAS-2051: Adds environment variable option for AWS_ACCESS_TOKEN (#82)
Browse files Browse the repository at this point in the history
  • Loading branch information
flamingbear authored Dec 19, 2023
1 parent 9525d68 commit f75472f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions test/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ ENV env_notebook=$notebook

ENV AWS_SECRET_ACCESS_KEY=no-access
ENV AWS_ACCESS_KEY_ID=no-access
ENV AWS_SESSION_TOKEN=no-access
ENV AWS_REGION=us-west-2

ENV PYTHONDONTWRITEBYTECODE=true
Expand Down
2 changes: 1 addition & 1 deletion test/n2z/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.1.4
0.1.5
8 changes: 5 additions & 3 deletions test/run_notebooks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ for image in "${images[@]}"; do

# insert AWS Credential variables for n2z only
if [[ $image == "n2z" ]]; then
creds="--env AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} --env AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}"
creds="--env AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} \
--env AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} \
--env AWS_SESSION_TOKEN=${AWS_SESSION_TOKEN}"
else
creds=""
fi
Expand All @@ -57,7 +59,7 @@ trap ctrl_c SIGINT SIGTERM

function ctrl_c() {
echo "Cleaning up"
for name_comma_pid in ${PIDS[@]}; do
for name_comma_pid in "${PIDS[@]}"; do
name_pid=(${name_comma_pid//,/ })
echo "Killing ${name_pid[0]}"
docker kill "${name_pid[1]}" >/dev/null
Expand All @@ -69,7 +71,7 @@ function ctrl_c() {

exit_code=0
# wait for processes to finish and store each exit code into array STATUS'
for name_comma_pid in ${PIDS[@]}; do
for name_comma_pid in "${PIDS[@]}"; do
name_pid=(${name_comma_pid//,/ })
name=${name_pid[0]}
pid=${name_pid[1]}
Expand Down

0 comments on commit f75472f

Please sign in to comment.