fix: deprecation of xarray Dataset.dims #247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #246
Description
Update
core.py
to reflect xarrayDataset.dims
deprecation in favour ofDataset.sizes
.Local test steps
Ran without any arguments comparing two identical file copies (taken from https://www.unidata.ucar.edu/software/netcdf/examples/files.html). The proposed changes resolves the
FutureWarning
.Overview of integration done
I couldn't find docs for this in contributing so I'm assuming this is referencing an internal process.
PR Acceptance Checklist
CHANGELOG.md
updated📚 Documentation preview 📚: https://ncompare--247.org.readthedocs.build/en/247/