Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nasa/nos3#227] Propulsion #341

Merged
merged 16 commits into from
Aug 6, 2024
Merged

[nasa/nos3#227] Propulsion #341

merged 16 commits into from
Aug 6, 2024

Conversation

msuder
Copy link
Contributor

@msuder msuder commented Jul 23, 2024

Pull request to add in new generic_thruster component to NOS3 dev branch.

msuder added 14 commits July 1, 2024 13:21
@msuder
#227 - Start at generic thruster component. Code is from sample app f…
c6e2bf3 
…or now.
@msuder
#227 - Start at generic thruster component. Code is from sample app f…
05095c5 
…or now.
@msuder
#227 - Start at generic thruster component. Code is from sample app f…
f447be1 
…or now.
@msuder
#227 - Start at generic thruster component. Code is from sample app f…
b7cd635 
…or now.
@msuder
#227 - Tweaks
6a5804f
@msuder
#227 - Submodule updates.
1a9f6f3
@msuder
#227 - Add thruster MIDs to TO output tables. Submodule update.
bd82995
@msuder
#227 - Submodule update.
01177b5
@msuder
#227 - Add missing connection block for thruster sim to sim config. S…
88ecc2e 
…ubmodule update.
@msuder
#227 - Add thrusters to 42 spacecraft file. Submodule update.
ce7ce68
@msuder
#227 - Submodule pointer update.
449fef1
@msuder
#227 - Configure S/C with 6 thrusters and modified the full thrust va…
2ebd3e4 
…lue.
@msuder
#227 - Tweak the thrusters.
13d079a
@msuder
#227 - Submodule update.
fae88c8
@msuder msuder requested a review from jlucas9 July 23, 2024 14:49
@msuder msuder self-assigned this Jul 23, 2024
@msuder
Copy link
Contributor Author

msuder commented Jul 25, 2024 •
edited
Loading

To test:

  1. Run NOS3
  2. Send command to enable thrusters
  3. Send command(s) to set thruster (0 to 3) to a percentage of full thrust
  4. Observe the spacecraft reacts and rotates and/or translates

@matt11matthew
Copy link

Question relating to thrusters, are they supposed to be used to increase velocity or only used for visualization?

@msuder
Copy link
Contributor Author

msuder commented Jul 31, 2024

The thrusters can be used to linearly accelerate and/or rotationally accelerate the spacecraft.

@Isgaroth-the-Green
Copy link
Contributor

Isgaroth-the-Green commented Aug 1, 2024 •
edited
Loading

Does 42 keep track of any orbital data (perigee, apogee, right ascension, and things like that)? Given the existence of the 42 map it looks like it does.

Isgaroth-the-Green
Isgaroth-the-Green approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks like it works; I did not have any trouble with running it, and it does (as far as I can tell) what it is supposed to.

@jlucas9 jlucas9 changed the title Nos3 227 propulsion [nasa/nos3#227] Propulsion Aug 1, 2024
@jlucas9 jlucas9 merged commit fc47c0e into dev Aug 6, 2024
4 checks passed
@jlucas9 jlucas9 deleted the nos3-227-propulsion branch August 6, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isgaroth-the-Green Isgaroth-the-Green Isgaroth-the-Green approved these changes

@jlucas9 jlucas9 jlucas9 approved these changes

Assignees

@msuder msuder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msuder @matt11matthew @Isgaroth-the-Green @jlucas9