Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nasa/nos3#378] arducam checkout #397

Merged
merged 3 commits into from
Oct 29, 2024
Merged

[nasa/nos3#378] arducam checkout #397

merged 3 commits into from
Oct 29, 2024

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Oct 24, 2024 •
edited
Loading

Updated arducam to include the fsw/shared folder and a minimally functional standalone or checkout application.

Requires the following submodules to be merged prior:

Closes #378

Testing:

  • Build
    • git checkout nos3#378-arducam-checkout
    • git submodule update --init --recursive
    • make
    • make debug
    • cd ./components/arducam/fsw/standalone
    • mkdir build
    • cd build
    • cmake .. -DTGTNAME=cpu1
    • make
    • exit
    • make checkout
  • Test
    • In the arducam checkout, try a NOOP
    • Confirm in the Arducam sim that both I2C and SPI appear

image

@jlucas9
[#378] Arducam reformatted to include fsw/shared folder and created f…
8597ec3 
…unctional checkout with simulated hardware NOOP;
@jlucas9 jlucas9 self-assigned this Oct 24, 2024
@msuder
Copy link
Contributor

msuder commented Oct 28, 2024

Pulled and tested according to procedure above. It all works as stated. I approve this pull request.

dacarter22
dacarter22 approved these changes Oct 28, 2024
View reviewed changes
Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to run code successfully, no errors spotted on my ned.

@jlucas9 jlucas9 merged commit 32a7034 into dev Oct 29, 2024
4 checks passed
@jlucas9 jlucas9 deleted the nos3#378-arducam-checkout branch October 29, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacarter22 dacarter22 dacarter22 approved these changes

@msuder msuder msuder approved these changes

@kevincbruce kevincbruce Awaiting requested review from kevincbruce

@rjbrown2 rjbrown2 Awaiting requested review from rjbrown2

@dccutrig dccutrig Awaiting requested review from dccutrig

@zlynch2 zlynch2 Awaiting requested review from zlynch2

@Isgaroth-the-Green Isgaroth-the-Green Awaiting requested review from Isgaroth-the-Green

Assignees

@jlucas9 jlucas9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlucas9 @msuder @dacarter22